Check collection type before transforming #183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrooksuk
requested changes
Sep 3, 2024
| @@ -76,6 +77,12 @@ public function __construct($apiKey = null, ?HttpClient $guzzle = null) | |||
| */ | |||
| protected function transformCollection($collection, $class, $extraData = []) | |||
| { | |||
| if (!is_array($collection)) { | |||
| throw new Exception( | |||
| "Unexpected response format. Expected an array, got " . gettype($response) | |||
There was a problem hiding this comment.
$response is not a variable in this scope.
|
@LarryBarker I'm closing this as it's been stale for a while, but feel free to implement the feedback from the review and we can look to open this again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve Error Handling in Forge SDK
Description
This PR aims to enhance the error handling capabilities of the Forge SDK, specifically addressing issues related to unexpected API responses and improving the overall robustness of the SDK.
Changes Proposed
transformCollection()method in theForgeclass to implement more robust error checking.Motivation and Context
Recent issues with API integrations have highlighted the need for more robust error handling within the Forge SDK. Specifically, unexpected response formats from the API have led to unhandled exceptions, causing disruptions in applications using the SDK.
This PR addresses these issues by implementing best practices for API error handling, as outlined in various resources:
How Has This Been Tested?
Types of changes
Checklist:
Additional Notes
This PR is part of a larger initiative to improve the overall reliability and user experience of applications integrating with the Forge SDK.